stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
8.92k stars 780 forks source link

[Feature] Multiple performer image #571

Open Cromseth opened 4 years ago

Cromseth commented 4 years ago

It would be great to allow save a few images at performer entity and not just one like now. I like to ocassionally surf the net searching for great profile images for girls in my database, and it would be nice to keep more that one (maybe with a limit?) and show one randomly as default or visible each session (or something like that). I mean something that don't suppose extra work to devs, just to see a little more "variety" and "eyecandy".

Maybe store a few images and the possibility to change the "default" manually from perfomers page? I dont know what would be more simple.

Sorry for my english again!

Cromseth commented 4 years ago

Maybe just allow a "slideshow" in performers tab if it is problematic somewhere else. It could change the performer image at t=x or something like that...

performers

seducingbits commented 4 years ago

It's on the road map for medium term https://github.com/stashapp/stash/wiki/Roadmap#multiple-performer-images

I like the idea. Both the option just to have multiple images which are just rotating around and the option to tag the images like potrait, clothed, nude and select the image you want to see preferably for all performers which have one of that category.

Cromseth commented 4 years ago

It would be interesting with that variables to images at DB... My idea is much more simple, maybe is more "doable" at short time.

bnkai commented 4 years ago

The roadmap was made a long time ago. Having it as an issue was needed anyway. Both suggestions made here will need to be addressed after we figure out what we'll do with images in the DB as there is an issue whether images should be stored in a separate table in the DB ( easier to implement for now ) or in the fs. With the current schema there is no way to add a non fixed number of images to a performer easily.

WithoutPants commented 3 years ago

$20 bounty placed (8-Sep)

WithoutPants commented 2 years ago

$50 bounty placed. Total bounty now $70

Ch00nassid commented 2 years ago

The description reminds me of the setup i had in Pornvault: https://github.com/stashapp/stash/issues/124#issuecomment-822048693

I had a "Primary thumnail", which i would have fully front nude. I then had "Alt Thumbnail" which i put fully clothed. There was also a "hero image" which was a 16:9 spread near the top.

On the performers page, i would hover over the image and it would either dress or undress the performer -- depending on the mood i was feeling.

QxxxGit commented 2 years ago

I dunno how far this will be taken but if the performer page and cards gets a refactor/update like settings, I think a discussion might be necessary on how to implement multiple performer images based on community feedback. People, especially those that paid the bounties, may have different ideas of what they're looking for.. i.e.

And personally one thing I'm hoping for is the ability to crop performer images before applying.

QxxxGit commented 2 years ago

I posted this in the discord the other night and thought I'd drop it here since it was received very well.

In photopea, I came up with a concept for a new performer page including multiple performer images.

new

Some notes:

On mobile:

Additional thoughts:

Ch00nassid commented 2 years ago

I posted this in the discord the other night and thought I'd drop it here since it was received very well.

In photopea, I came up with a concept for a new performer page including multiple performer images.

new

Some notes:

  • The edit button is moved to the navigation. We currently rest the 'New' button in this location when creating new records so for consistency I put it there. Should this be the standard for all record detail pages (i.e. tag, scene, etc)? That being said, I think the edit button could also sit fine next to the auto tag and delete buttons.
  • The margins would need to be adjusted. We could shift everything a little further to the right to look more centered.
  • If there's a desire in the future, the left and right sides of the page could be hovered to display a darkened/transparent gradient with the previous/next performer's profile pic. Clicking this would take you to the previous/next performer according to the filters set beforehand on the performers list.
  • I forgot to add a section for the bio. However, this could sit above the search or with the rest of the details on the right column.
  • A crop feature before applying the images would go a long way.
  • Hovering the large performer image would show a pencil icon at the bottom left of it. Clicking it would allow you to edit all performer images.

On mobile:

  • The banner and profile pic would be displayed while the large performer image (right column) is hidden.
  • The details would be displayed immediately below the performer's name, age, and icon links; however, there would be a transparent gradient to cut it off half way with an icon to expand all the details.
  • Following the details would be the search and scenes, galleries, images, and movies tabs. Swiping left/right on the overall list of media items would switch the tab.

Additional thoughts:

  • I forgot to add the pagination and the current search filter section. I'm thinking the current filter would be display on the left under the search, and the pagination would be on the same row but floated to the right underneath the tabs.

Wow, I REALLY like this!!!!

I know that this might be asking alot but that thumbnail, can you hover over it and it will show a different picture? That would be really cool (and steal my heart 100%)

AdultSun commented 2 years ago

I saw this concept design on Discord and like it a lot too. Some additional notes to consider if you plan on making a new draft:

echo6ix commented 2 years ago

The poster and details area on the right side looks good on it's own, but as a cohesive design with the left column it completely kills it for me too, and it just takes up too much space for something that's static. Plus, there's an avatar, a hero image, and an auxiliary image, all static redundant content that take up a lot of viewport space.

I feel like instead of reinventing the wheel we should be taking inspiration from tube sites. They've already solved this problem and achieved the showcasing of different content such as multiple performer images that some people seem to desire.

Notice on many tube sites, a performer/model/user's page will have a landing page that summarizes all their content in rows of cards. The first row of cards would be images (there's your auxiliary performer images that people want). The second row would be scenes. The third row could be fresh scenes. Etc. Doing it like this, where each row of cards is basically using a different filter for content -- I could see that being more customizable in the future where users get to globally summarize what rows of content a performer landing page will show. Much better instead of hardcoding a specific image that uses up a lot of space, and more amenable to various viewport sizes.

QxxxGit commented 2 years ago

The poster and details on the right-hand side is wigging me out, oddly enough. Following the design of all the other pages in Stash would align those on the left side instead, which feels pretty standard for these kinds of media pages.

The main issue with this concept when considering the above point is that both StashDB and actress-pics require their landscape images to be 16:9, while the banner image above looks to be much narrower than that. It would probably be preferable for any kind of Wide/Landscape image type to be better compatible with those 16:9 images, otherwise it would result in some odd looking crops.

@AdultSun Updated to move the poster and details to the left. I do think you're right that it looks better and it's more in-line with the rest of the page layouts.

1

To your second point, I'm not sure what the solution is. I think the banner makes the page pop. It's possible for the banner to have a default unset image like when you create a new performer, and then just let the user add in their own. In another draft, I removed the banner and went with an Instagram-inspired profile info.

iglook

Plus, there's an avatar, a hero image, and an auxiliary image, all static redundant content that take up a lot of viewport space.

Notice on many tube sites, a performer/model/user's page will have a landing page that summarizes all their content in rows of cards. The first row of cards would be images (there's your auxiliary performer images that people want). The second row would be scenes. The third row could be fresh scenes. Etc. Doing it like this, where each row of cards is basically using a different filter for content -- I could see that being more customizable in the future where users get to globally summarize what rows of content a performer landing page will show. Much better instead of hardcoding a specific image that uses up a lot of space, and more amenable to various viewport sizes.

@echo6ix Unless I'm misunderstanding you, this is the whole point of the thread: users being able to add and customize multiple images to represent a performer. Other projects like Stash do the same thing (i.e. P-Vault which also uses a banner). The example Trax site you linked in Discord, in my opinion, was a bit of an eyesore and overwhelming with content. I also think the way you described it either pushes the search functionality very far down or removes it entirely; both of which are undesirable IMO because the tool is going to be much more useful than the rows of cards with customization. The search functionality already exists too whereas the card customization would be further development time.

echo6ix commented 2 years ago

@QxxxGit I am going to try and express the issue another way.

Your layout basically has two columns:

Column # Column size Content
1 25-33% auxiliary performer image and a bio summary
2 66-75% everything else, namely the scenes/images/galleries/movies and any future content such as relationships and studios

For reference, by tabs I am referring to the navigation links that read Scenes, Images, Galleries, Movies.

When a user scrolls down the page (to view more content within Column 2) it will quickly render Column 1 no longer viewable. 1/3 of the viewport is now completely wasted with a void. No matter what I do, I will only have 2/3 of the screen to view content. That's a huge misuse of space. So while you may find Traxxx to be an eyesore, it actually accomplishes what you're trying to achieve without compromising 1/3 of horizontal screen real estate (because literally the first row of content on a Traxxx page are a performer's auxiliary images)

You could say a solution would be to make Column 1 fixed in it's position. Aesthetically you would no longer have a 1/3 void when you scroll down the page, but functionally when I want to look at content from the tabs I am only getting 2/3 of the viewport to consume my content.

Creating a column dedicated to a large performer image is a big commitment to a page that is meant for more than just looking at their auxiliary image.

So what I am suggesting is have the performer's page be only one column wide; to put the auxiliary images (and biographical data) beneath the tab buttons.

Make the auxiliary image part of the performers "Details" tab. The details tab as it is contains actually little data relative to the entire screen. The details data could be realistically presented in 2 or 3 columns (depending on the size of the screen); there is more than enough space to add the performer's auxiliary photo on the details tab, and have the biographical data placed to it's left or right.

TL;DR A two column layout of these proportions is a misuse of space. You can achieve this feature request with a one column layout. Place the auxiliary performer images into the "Details" section; modify the "Details" section into a two or three column layout.

QxxxGit commented 2 years ago

@echo6ix I think using one column would end up pushing the things you want to see further down (i.e. search functionality), and I think we can solve this empty space in column 1 with future functionality.

Below the details in column 1, there can be suggested/recommended content. Anything from "Recommended Performers" to "Most Viewed Scenes/Images/Galleries" could fit here.

So imagine below details in column 1 a header of "Recommended Performers" that displays the circular profile pics of related performers based on similar tags or appearance (hovering a profile pic would display their name). Below this header is another header of "Most Viewed Media" which shows a scene, gallery, and image (or whatever we decide to put here in the future).

Because I do think you're right about the empty space being wasted; and I think this could fix that problem while giving some form of a "pinned content" feature as well. There's currently #1986 which is being pursued, and I think something like that would help in forming the recommended performers functionality. On discord, there was a small discussion at some point about implementing view counters for media (after video js implementation so the scenes could have a % watched to increment a view counter).

There's a ton of ways we could fill the column's empty space and I think there's much more benefit to having two columns instead of one. Two columns would be future proofing whereas adding functionality to a one column page would get cluttered quickly and necessitate a redesign anyways.

Edited for example

instagramlook2

Nalla22 commented 2 years ago

Is it possible today to put several profile pictures for personality?

scruffynerf commented 2 years ago

Someone posted a large group of 9:16 photos "to better show actress head/torso/hips without wasted space. Each Alt is of the same pic set with the actress turned around." They are geared for use in Porn Vault, where a mouse-over turns the actress around. This is a nifty feature, but right now, Stash lacks the ability to take advantage of this (the technical side is easy enough: use image1, and on mouse-over, use image2) but we don't have multiple images. We've discussed adding multiple performer images above (StashDB already supports them) so hopefully Stash will get that eventually. Consider this a request to specifically make it possible to do the above: have a main photo and secondary photo choice, so this sort of mouseover could work. Could be SFW and NSFW, or front/back like the over, or clothed/naked, or any other 2 photo combo you wished... maybe just headshot and candid, etc.

sleetx commented 2 years ago

"Each Alt is of the same pic set with the actress turned around." They are geared for use in Porn Vault, where a mouse-over turns the actress around. This is a nifty feature, but right now, Stash lacks the ability to take advantage of this

a dual performer profile photo would be an interesting feature. I vote for front + back being the most useful, as long as the back is their entire frame. Helpful especially if they have identifiable markings not visible in their primary photo (tattoos, etc).

In terms of functionality, it would save people time if these secondary photos can be scraped from StashDB. So the work probably needs to start there - enabling a primary and secondary photo for every performer, adhering to this theme. And then enabling Stash to pick up on it.

Jigglyscruff commented 2 years ago

I keep receiving these notifications, please remove me fromthe subscription list, I’m unable to log I to my original GitHub to remove myself from this.

On Mon, Aug 22, 2022 at 5:53 PM sleet @.***> wrote:

"Each Alt is of the same pic set with the actress turned around." They are geared for use in Porn Vault, where a mouse-over turns the actress around. This is a nifty feature, but right now, Stash lacks the ability to take advantage of this

a dual performer profile photo would be an interesting feature. I vote for front + back being the most useful, as long as the back is their entire frame. Helpful especially if they have identifiable markings not visible in their primary photo (tattoos, etc).

In terms of functionality, it would save people time if these secondary photos can be scraped from StashDB. So the work probably needs to start there - enabling a primary and secondary photo for every performer, adhering to this theme. And then enabling Stash to pick up on it.

— Reply to this email directly, view it on GitHub https://github.com/stashapp/stash/issues/571#issuecomment-1223156386, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTH4LAS7EBCNE6RTOQGCE3V2PZGDANCNFSM4NH2366Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

scruffynerf commented 2 years ago

To be clear, I'm not suggesting Stash pick front/back etc.

Nor does StashDb have to do anything new: it already supports multiple images. I'm not asking for change on Stashdb, it's fine. Stash lacks the ability to add more than one, and I'm just saying when (not if) it's added, please make it support more than just "primary" photo select (which is basically what we have now on both)

I want only 1st/2nd photo (main/alt). Let people make themes to support this, and decide what they want on mouseover. Don't call it front/back, etc.

echo6ix commented 2 years ago

To be clear, I'm not suggesting Stash pick front/back etc.

Nor does StashDb have to do anything new: it already supports multiple images. I'm not asking for change on Stashdb, it's fine. Stash lacks the ability to add more than one, and I'm just saying when (not if) it's added, please make it support more than just "primary" photo select (which is basically what we have now on both)

I want only 1st/2nd photo (main/alt). Let people make themes to support this, and decide what they want on mouseover. Don't call it front/back, etc.

Right. This is a good point. If you look at the roadmap for this proposed feature (assuming it's still a viable feature)

Adding multiple images for a performer seems like a good change. Make them taggable so the user can configure what type of images they see when they see a performer card.

Your idea of the client being image category agnostic could slot right into this. ^

sleetx commented 2 years ago

It sounds like the request here is to allow the user to pick from one of a performer's StashDB images to set as the "alt". To my knowledge there hasn't been a StashDB effort to upload any specific performer images besides the primary portrait style. So if you're trying to go for a particular theme with the "alt" image, it will be a mixed bag if you find what you're looking for.

echo6ix commented 1 year ago

I'm not particular for or against this feature, but if this is ever added I hope it will just introduce a new method of interfacing with the existing image section built into Stash. I would hope it's not going to add some distinct repo of performer images walled off from the rest of the Stash images. That would create unnecessary redundancy and overlap.

miltuss commented 6 days ago

Films/Groups in stash are entitled to two cover images, while performers are only entitled to one profile image!

I would like to use a standard profile image for performers and another NSFW image.

This could be done in different ways:

1 - Mouse Rover on the performer card to display the second image 2 - directional arrow on the card to scroll to the second image 3 - Button on the card to switch from one image to another ...

All these methods of displaying the second image can be offered in the settings to the user and let him choose the one he prefers.