search

stashapp / stash

An organizer for your porn, written in Go. Documentation: https://docs.stashapp.cc
https://stashapp.cc/
GNU Affero General Public License v3.0
9.19k stars 793 forks source link

[Feature] Cover Image usability improvements + metadata #950

Open Hoowah opened 3 years ago

Hoowah commented 3 years ago

I wasn't sure if it would clutter the issue list if I broke these down, so I put all my thoughts on this topic in one issue. Sorry if that makes it more difficult to track the individual suggestions.

Generating custom cover images for scenes is awkward at the moment.

1) It seems to make a lot more sense to move the "Generate thumbnail from current" and "Generate default thumbnail" actions from the extraneous menu to the Cover Image section of the pane.

2) The Cover Image preview doesn't update when generating from the current frame or default thumbnail until you hit save.

3) One day I hope we can have frame forward and back controls, but for now the least the scene player could do is not resume playback when you seek paused video.

On to feature suggestions:

4) Does stash have a way to determine if a scene has a custom cover image or not? If a user is invested in making custom covers, they need a way to filter out scenes they have already done. I think a "custom_cover_image" variable in the "Is Missing" filter is the perfect place for it. This would apply for both frame-generated covers and covers from an image file.

5) When a user generates a cover image from a video frame, does stash remember the frame number in metadata? I couldn't find it. I think it could pay off later to start doing this now. One day if we have a realized scene database, users could contribute their custom cover frame numbers. Could these be heatmapped and auto-suggested when users fingerprint/request metadata for scenes?

Concept images:

thumbnail generation custom_cover_image

Gykes commented 1 month ago

@WithoutPants

There are a few smaller changes in this FR. I can start tackling them one at a time, making individual PRs for each change.

For issue 1 is this something that you are wanting done or would you rather it be kept in the dropdown?

WithoutPants commented 1 month ago

For issue 1 is this something that you are wanting done or would you rather it be kept in the dropdown?

I think it makes sense to group these items with the set cover image button rather than the overflow menu.