search

stashed / stash

🛅 Backup your Kubernetes Stateful Applications
https://stash.run
Other
1.32k stars 86 forks source link

ARM support for pushgateway #826

Open ljani opened 5 years ago

ljani commented 5 years ago

802 says "We now use Docker manifest to build and push ARM images", but I cannot find ARM images on Docker Hub. Am I missing something? Here's output from manifest-tool:

> manifest-tool inspect appscode/stash:0.8.3
appscode/stash:0.8.3: manifest type: application/vnd.docker.distribution.manifest.v2+json
      Digest: sha256:e75f159dbf98a43e29d2fbfb2f851e15309da706c0e5849cebce9c7f73d41d43
Architecture: amd64
          OS: linux
    # Layers: 4
      layer 1: digest = sha256:169185f82c45a6eb72e0ca4ee66152626e7ace92a0cbc53624fb46d0a553f0bd
      layer 2: digest = sha256:123a490c702d28373eb122b9703ff85ca919b94edc35ef1846f5edc2842f09ad
      layer 3: digest = sha256:bb5c0e940e6fa9141f70a65bbc1878cca37802727546fa3b732230a312ea2f4b
      layer 4: digest = sha256:671a412b35bc2cb03b27ec905cb4a5d71da54135dd4b518e9aa32f1775e17c7d

I'm using helm to deploy stash and I tried to switch nodeSelector.beta.kubernetes.io/arch to arm without any luck.

EDIT: also pushgateway needs an ARM image:

> manifest-tool inspect prom/pushgateway:v0.5.2
prom/pushgateway:v0.5.2: manifest type: application/vnd.docker.distribution.manifest.v2+json
      Digest: sha256:4c9fa582c167f6fec89c6ebbd454ec1b5dba3ee0e1e21118fac6737c06861f92
Architecture: amd64
          OS: linux
    # Layers: 4
      layer 1: digest = sha256:f70adabe43c0cccffbae8785406d490e26855b8748fc982d14bc2b20c778b929
      layer 2: digest = sha256:b91f96ddd9e3d9eba3f591b3d0aec7cf584597bbb74e437338b3a2d56716dd35
      layer 3: digest = sha256:3693ae9b6e8c27fab05d3ae2239fc8261736fe4650af7943a869ddebf3f930a4
      layer 4: digest = sha256:3e4f5d9c35a511de6fd43ee4e20c2062e1fc17b5f6908068ffd7e8c272cd051f
hossainemruz commented 5 years ago

@ljani we haven't released any new version with this PR. We will cut a release soon.

ljani commented 5 years ago

Ah, that makes sense. I'll be waiting for the release, thanks!

hossainemruz commented 5 years ago

We have published the ARM images. Feel free to reopen if not fixed.

jdmarble commented 4 years ago

I got this working with some Helm chart overrides:

    nodeSelector:
      beta.kubernetes.io/arch: arm64
    pushgateway:
      tag: v1.2.0
    cleaner:
      registry: rancher
      repository: kubectl
      tag: v1.17.0

I think it would be possible to make it work out-of-the-box on both arm and amd64 with some tweaks to the default values:

hossainemruz commented 4 years ago

Thank you @jdmarble . I am re-opening this issue so we don't lose this info.