Don't require '@' to ping player

stashymane / extra-sounds

Creative Commons Zero v1.0 Universal

39 stars 21 forks source link

Don't require '@' to ping player #12

Closed jackmawer closed 3 years ago

jackmawer commented 3 years ago

Lots of minecraft users use IRC style mentions (its_notjack: Blah blah), and also the user's name may be mentioned by other messages, and it's probably still useful for them to get pinged when their name is mentioned in them.

jackmawer commented 3 years ago

an unintended side effect that I totally overlooked was that every chat message sent by a user then causes the ping sound to play 🤦 not sure how to work around that

stashymane commented 3 years ago

I can think of a workaround, however it's still going to be inconsistent as only the server has knowledge of which part of the message actually is the player name, especially with custom formatting. For now this will stay as-is.