search

stashymane / extra-sounds

Creative Commons Zero v1.0 Universal
39 stars 21 forks source link

Added lightweight config support using cloth config #30

Closed DerLeole closed 2 years ago

DerLeole commented 2 years ago

I added a granular config for every single sound feature using Cloth Config. I also added mod menu support which allows players to toggle each sound during runtime without any restarts.

The entire build filesize is only 7kbs bigger than before. The Mod requires cloth config using this change though, I think. This should be no problem though as most other mods require it these days.

stashymane commented 2 years ago

Although I would love all configuration to be done with resource packs as having to configure everything adds unnecessary clutter, since many people show interest in configuration options I think at least having the option to do so would be best. However, since we already have custom sound categories working properly with near-vanilla GUI with my other library, adding another dependency (cloth config) seems unnecessary - instead of having simple on/off switches for separate sounds, I would rather have the option to change the sound levels as well. Therefore, I think the best option right now would be to extend the Sound Categories library to include an extra screen for more in-depth sound control. I'm leaving this open for now while I work on adding this to Sound Categories, in case it is too expensive in terms of time to implement more in-depth control that way.

DerLeole commented 2 years ago

Glad to hear this. I mostly wrote this for my own personal use as I was not too familiar with resource pack options.

As for sound category expansion, I am also in favour of this, but wanna advocate for a high granularity system, i.e being able to have chat sounds off but chat mentions on.

Alternatively, the Cloth config could easily be replaced by another config solution or its own ingame UI, as my edit realies only on booleans it can get from the main mod class. However I think a cloth config as a dependency is not neccasarily a problem as any installation with more than 20 mods (very likely 99% of potential users) will already have cloth config in some form installed for another mod :D

Looking forward to what you come up with!

stashymane commented 2 years ago

More granular categories have now been added, any more specific configuration will need to be done with resource packs - my next goal is an easy to use web app for configuring sounds.