search

stashymane / extra-sounds

Creative Commons Zero v1.0 Universal
40 stars 21 forks source link

1.19.1 support? #71

Closed 19lmyers closed 2 years ago

19lmyers commented 2 years ago

I noticed the mod does not work on 1.19.1. How feasible is it for support to be added?

lonefelidae16 commented 2 years ago

Same here, I can’t wait to 1.19.1 support. So I have wrote the patch and I’ll share my code.

ttrafford7 commented 2 years ago

does your instance crash while trying to launch it?

akemin-dayo commented 2 years ago

I've added support for Minecraft 1.19.2 and 1.19.1 in my fork of ExtraSounds.

I actually made this fix a few… weeks ago for private use but I may have uh… completely forgot to actually push and submit/publicise my changes as a PR (which is now PR #74). Oops. Better late than never though, I guess…?

The source code is freely available for those who want to see exactly what was changed, and/or those who prefer building their own binaries locally.

I've changed the version number to 2.3.1+1.19.2-1.19.1~akemi (plus the Git commit short SHA-1) in order to clearly differentiate it from the official upstream ExtraSounds versions.

※ IMPORTANT NOTE: Minecraft 1.19 is no longer supported with these changes. For more information, see PR #74.

If you're just a normal user (non-developer) who just wants to use ExtraSounds on 1.19.2/1.19.1 right this instant…

If you don't want to build ExtraSounds yourself, and you trust me / are comfortable running unofficial binaries from me, here's a prebuilt jar that you can just drop into your mods/ folder:

https://developer.akemi.ai/Minecraft/extrasounds-2.3.1+1.19.2-1.19.1~akemi-git-7a58d66.jar

stashymane commented 2 years ago

Version released :)