If you're just a normal user (non-developer) who just wants to use ExtraSounds on 1.19.2/1.19.1 right this instant…
If you don't want to build ExtraSounds yourself, and you trust me / are comfortable running unofficial binaries from me, here's a prebuilt jar that you can just drop into your mods/ folder:
Added support for Minecraft 1.19.2 and 1.19.1, fixing issue #71.
I actually made this fix a few… weeks ago for private use but I may have uh… completely forgot to actually push and submit the PR. Oops. Better late than never though, I guess…?
※ IMPORTANT: Please note that this commit completely breaks support for Minecraft 1.19 due to Yarn mapping changes!
For this reason, I think it would be a good idea to merge this PR into a completely new branch, as opposed to into the existing 1.19 branch, unless if you intend to drop support for 1.19 in the future.
And yes, issue #69 still occurs on 1.19.2 and 1.19.1. The issue appears to be some sort of mixin conflict happening in your SoundCategories library (I haven't taken a close look at it yet, will do so when I have more time.)
Changes made:
gradle.properties: Target Minecraft 1.19.2 in gradle.properties — this is still compatible with 1.19.1!
ChatSound.java: Update method signature used for pickup() hook, as it is now completely different as of 1.19.1.
If you're just a normal user (non-developer) who just wants to use ExtraSounds on 1.19.2/1.19.1 right this instant…
If you don't want to build ExtraSounds yourself, and you trust me / are comfortable running unofficial binaries from me, here's a prebuilt jar that you can just drop into your
mods/folder:https://developer.akemi.ai/Minecraft/extrasounds-2.3.1+1.19.2-1.19.1~akemi-git-7a58d66.jar
Added support for Minecraft 1.19.2 and 1.19.1, fixing issue #71.
I actually made this fix a few… weeks ago for private use but I may have uh… completely forgot to actually push and submit the PR. Oops. Better late than never though, I guess…?
※ IMPORTANT: Please note that this commit completely breaks support for Minecraft 1.19 due to Yarn mapping changes!
For this reason, I think it would be a good idea to merge this PR into a completely new branch, as opposed to into the existing
1.19branch, unless if you intend to drop support for 1.19 in the future.And yes, issue #69 still occurs on 1.19.2 and 1.19.1. The issue appears to be some sort of mixin conflict happening in your SoundCategories library (I haven't taken a close look at it yet, will do so when I have more time.)
Changes made:
gradle.properties: Target Minecraft 1.19.2 in gradle.properties — this is still compatible with 1.19.1!ChatSound.java: Update method signature used forpickup()hook, as it is now completely different as of 1.19.1.