search

stashymane / extra-sounds

Creative Commons Zero v1.0 Universal
39 stars 21 forks source link

Do not register sounds #79

Closed Binero closed 1 year ago

Binero commented 2 years ago

This is a client-side modification. Minecraft does not require sounds that are client-only to be registered to play them. Simply removing the register call while keeping everything else intact should work fine.

This would make Extra-Sounds compatible with servers that have custom sounds of themselves. Right now the game will refuse to connect to those servers because the server has a different registry.

stashymane commented 1 year ago

Done in v3, the way I was working on this initially made it seem like events have to be registered before they can be used. Small oversight.