Open lonefelidae16 opened 1 year ago
Will release new SoundCategories version tomorrow after testing, i'll bump the version myself, thanks :)
i'll bump the version myself
Sorry for my misunderstanding, but I thought I needed to wait for a new version of SoundCategories, write the gradle.properties
myself, then create a new commit and mark this PR as ready. But reading your comment again, I don’t think that is necessary.
I have now marked this PR as ready, my bad.
Any updates?
yeah 1.19.4 stable is out but I still can’t find the new SoundCategories release, perhaps I was quite an idiot for seriously creating this pull, haha.
As you can see, I’m impatient and can’t wait for official releases, so I have “UNOFFICIAL” ports of ExtraSounds and SoundCategories for my use. The code is available on my fork, and you can get the pre-built jars on my maven.
I know my decision may seem foolish and unwelcome to some. For now, modification and redistribution seem to be no problem, but if the license (of course including these libraries) or the owner reject this, I may stop publishing them.
~~How can I compile this myself? not sure how to get sound categories to work with extra sounds its complaining about sound categories mixins and failing~~
nvm figured it out kinda
Ah, I wrote it in #92 , but the content is out of date. That’s referring to branches that no longer exist... I would like to rewrite it anew in my Wiki. Update: seems no problem... but not completed. I’ll update as needed. https://github.com/lonefelidae16/extra-sounds/wiki
awaiting for a new release of SoundCategories...
Changes
update dependencies
gradle.properties
build.gradle
gradle-wrapper.properties
class usage has changed
new SoundEvent
->SoundEvent.of
mixin method signature has changed
inventory.InventoryClickSounds
,inventory.CreativeScreenHandlerSounds
net.minecraft.screen.ScreenHandler#transferSlot
->quickMove
EffectMixin
ClientPlayerEntity#<init>(ClientWorld, GameProfile, PlayerPublicKey)
-><init>(ClientWorld, GameProfile)
mixin field type has changed
inventory.CreativeInventoryClickSounds
net.minecraft.client.gui.screen.ingame.CreativeInventoryScreen::selectedTab
:int
->ItemGroup
import statement has changed
javax.annotation.*
->org.jetbrains.annotations.*
net.minecraft.util.registry.Registry
->net.minecraft.registry.*