staskobzar / vue-audio-visual

VueJS audio visualization components
MIT License
717 stars 112 forks source link

waveform overwrites another when 2 wavforms are on screen. #135

Open robertglatzel opened 1 year ago

robertglatzel commented 1 year ago

Hello, I've noticed an issue (or perhaps I'm missing something here) that when i have 2 waveform elements loaded, one's canvas will overwrite the other.

The workflow is: I record audio > it is then loaded into a waveform. I also load a song into a waveform.

When I click on the song waveform, it retains its waveform. When I click on the recording waveform, the song waveform is drawn over it.

My guess is that the canvas is being overwritten and is not unique to each instance.

Am i doing something wrong here, or is my assumption correct?

Thanks!

Screenshot 2023-05-06 at 12 33 39 PM Screenshot 2023-05-06 at 12 33 47 PM
staskobzar commented 1 year ago

Hello, No, it is unique per instance. Make sure you are not referencing to the same canvas element from different plugin instances. Probably I can say more if you see the code that generates those waveforms.

robertglatzel commented 1 year ago

Hello Stas, thank you for the response!

I can send you a screenshot of where i'm defining the component and calling it. It's odd because I am using the AV circle elsewhere and don't see any issues with it.

Let me know if you see something obvious :D

On Sat, May 6, 2023 at 1:04 PM Stas Kobzar @.***> wrote:

Hello, No, it is unique per instance. Make sure you are not referencing to the same canvas element from different plugin instances. Probably I can say more if you see the code that generates those waveforms.

— Reply to this email directly, view it on GitHub https://github.com/staskobzar/vue-audio-visual/issues/135#issuecomment-1537117739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIMVATJSLJTRGG3E62PAJTXEYV3RANCNFSM6AAAAAAXYA3TXE . You are receiving this because you authored the thread.Message ID: @.***>

staskobzar commented 1 year ago

Hi Robert, Sure, send me a screenshot or code so that I can re-create this bug to start fixing it.

robertglatzel commented 1 year ago

Hey Stas, awesome.

I actually tried sending them in the last email but maybe they didn’t go through. Could you send me an email address where I can contact you?

Mine is @.***

Thanks!

On May 8, 2023 at 4:02 PM, <Stas Kobzar @.***)> wrote:

Hi Robert, Sure, send me a screenshot or code so that I can re-create this bug to start fixing it.

— Reply to this email directly, view it on GitHub (https://github.com/staskobzar/vue-audio-visual/issues/135#issuecomment-1538412955), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AGIMVASEGFDWWINOWXRR4JTXFD4IJANCNFSM6AAAAAAXYA3TXE). You are receiving this because you authored the thread.Message ID: @.***>

staskobzar commented 1 year ago

my email is staskobzar@gmail.com

staskobzar commented 1 year ago

Hey Robert, Yes, there is a bug with multiple Waveform on the same page. I was able to re-create it. Thanks for reporting it and for the details. I will need to fix it. Will posts updates here. Have a good day!

staskobzar commented 1 year ago

Hey Robert, New version 3.0.5 with the fix is released. Please update and try

robertglatzel commented 1 year ago

Ah great, I’m glad you were able to replicate. Looking forward to it!

On May 9, 2023 at 10:33 AM, <Stas Kobzar @.***)> wrote:

Hey Robert, Yes, there is a bug with multiple Waveform on the same page. I was able to re-create it. Thanks for reporting it and for the details. I will need to fix it. Will posts updates here. Have a good day!

— Reply to this email directly, view it on GitHub (https://github.com/staskobzar/vue-audio-visual/issues/135#issuecomment-1539164840), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AGIMVAVJABUMBK5BYYYON2LXFH6M7ANCNFSM6AAAAAAXYA3TXE). You are receiving this because you authored the thread.Message ID: @.***>

staskobzar commented 1 year ago

@robertglatzel It is already released. You can try it