search

staskobzar / vue-audio-visual

VueJS audio visualization components
MIT License
717 stars 112 forks source link

Add space to av-waveform #55

Closed BigsmileAgency closed 3 years ago

BigsmileAgency commented 4 years ago

Hello,

First thanks for this plugin !! It's not realy a issue..

I've added the fonctionnality (adding space between line for av-waveform) and debug the playtime true/false..

Maybe you can add it in a future update !? :)

Line 33, 250, 302, 328, 388, 389, 399

AvWaveform.zip

Bruno

staskobzar commented 4 years ago

Hello Bruno,

Thank you for the contribution. Please, create a pull request with your updates so that I can see the diff and check merge conflicts.

Here is example on how-to create pull request: https://opensource.com/article/19/7/create-pull-request-github

Also, please, run "npm run test" and "npm run lint" before pushing to make sure there is no code conflicts and code style is ok.

If you have new props, please update README docs too.

Thank you

BigsmileAgency commented 4 years ago

Ok thanks !

Sry i’m a bit new with this ^^

I’ll do that when I can !