search

staskobzar / vue-audio-visual

VueJS audio visualization components
MIT License
693 stars 111 forks source link

playtime prop is not used #60

Closed andreasvirkus closed 3 years ago

andreasvirkus commented 3 years ago

Hi, thanks for a great audio visualization library! <3

I believe the drawTime function for Waveform should be called conditionally, only when props.playtime is true

https://github.com/staskobzar/vue-audio-visual/blob/0d6f2dde6fe39c0e3da696f0529895b574b7c326/src/components/AvWaveform.js#L293

Would you accept a PR for this change?

staskobzar commented 3 years ago

Hello Andreas,

Yes, sure. Please, create PR. Thank you!