search

staskobzar / vue-audio-visual

VueJS audio visualization components
MIT License
687 stars 109 forks source link

Modified the render function according to Vue 3.x syntax #79

Closed nsssayom closed 2 years ago

nsssayom commented 2 years ago

This fix solves Uncaught (in promise) TypeError: h is not a function error and makes the plugin usable in Vue 3 projects.

staskobzar commented 2 years ago

@nsssayom thank you for the code contribution. Unfortunately, it is not back compatible with vue v2. There is "demo" folder and when I run with the changes you provide AvMedia component is not working.

nsssayom commented 2 years ago

Yes, this is a Vue 3.0 only solution unfortunately. There can be another library named vue3-audio-visual for Vue v3.0 with this fix.

staskobzar commented 2 years ago

yeah, sorry, I can not merge it as it will impact people who is already using it. I keep it open though for future reference.

Also, you can publish your own vue3-audio-visual and I will put a reference in README so that anyone can use it before better solution is found. What do you think?

nsssayom commented 2 years ago

Yeah, it would be very convenient. I will publish a new plugin, and let you know here.

alectrocute commented 2 years ago

Maybe we should use vue-demi for this? We should make it a universal plugin, instead of forking IMHO.

staskobzar commented 2 years ago

Maybe we should use vue-demi for this? We should make it a universal plugin, instead of forking IMHO.

@alectrocute I did not know about this pluging. it looks like a good solution. Probably will not take too many changes to implement

staskobzar commented 2 years ago

@nsssayom I have published v2.3.0 which supports both vue2 and vue3. Please, try it let me know if you have any problems. Thank you

alectrocute commented 2 years ago

@staskobzar Maybe we should advertise that it's vue 2 and vue 3 compatible on the README.md?

staskobzar commented 2 years ago

@alectrocute good point, thank you