search

staskobzar / vue-audio-visual

VueJS audio visualization components
MIT License
717 stars 112 forks source link

Fix imports to remove warnings and support Vue2 & Vue3 #92

Closed NateBrady23 closed 2 years ago

NateBrady23 commented 2 years ago

This removes the "export 'h' was not found in 'vue' warning some may be seeing in Vue2 while maintaining compatibility with Vue2 & Vue3

NateBrady23 commented 2 years ago

https://app.codacy.com/gh/staskobzar/vue-audio-visual/pullRequest?prid=8834255 Codacy doesn't understand destructuring. Thinks these are "unnecessary blocks"

staskobzar commented 2 years ago

hello @nbrady-techempower and thanks for the contribution. I have tried in "demo" folder and I still see this message

"export 'h' (imported as 'vue') was not found in 'vue'

However, I have tried only in Vue2 and I do not know if it is the same for Vue3. Can you confirm in your case both versions have no warnings? Can you make sure you have clean setup: remove node_modules and do "npm install"

NateBrady23 commented 2 years ago

@staskobzar You're right. I was testing in my own project with a different webpack version. This worked for me now.

NateBrady23 commented 2 years ago

This also passes Codacy now

staskobzar commented 2 years ago

@nbrady-techempower thank you will publish your contribution tonight have a good day!