search

stasm / innerself

◘ A tiny view + state management solution using innerHTML
ISC License
778 stars 28 forks source link

WIP Selectors #22

Open stasm opened 7 years ago

stasm commented 7 years ago

Here's a WIP of my proposal to fix #19. I still need to add more tests and fix the failing ones. In the interest of gathering feedback early I'm submitting the PR now.

I split the change into three commits and it might be helpful to review them one by one.

stasm commented 7 years ago

I'll give this a closer look in the morning but at first glance this looks good. An example using combineReducers would be nice but certainly not necessary in this PR.

Thanks. I'll add an example and tests for combineReducers tonight or tomorrow. I also need to change the tests for connect. The ones I added in the first commit of this PR fail because the second commit changed the expected signature of connected components.

bcruddy commented 7 years ago

I also need to change the tests for connect. The ones I added in the first commit of this PR fail because the second commit changed the expected signature of connected components.

Once this is fixed 👍