include nvm and travis ci config, build with node 8/npm 5

stasm / innerself

◘ A tiny view + state management solution using innerHTML

ISC License

778 stars 28 forks source link

include nvm and travis ci config, build with node 8/npm 5 #25

Closed bcruddy closed 7 years ago

bcruddy commented 7 years ago

In reference to #24.

This includes:

.nvmrc to point at node 8
package-lock.json as a part of npm 5
travis config

I'd be happy to swap out node versions or another CI. I also obviously cannot set up the hooks for travis to run in this repo so if we do go the travis route that will need to be added.

stasm commented 7 years ago

@bcruddy Nice, I love this. Especially the CI part :) Do I need to enable Travis before and after this is merged?

bcruddy commented 7 years ago

Yeah if you enable the travis hook we can make sure everything runs as expected (it should run if I force push to the branch) before it gets merged

stasm commented 7 years ago

Alright, I've enabled the Travis hook for this repo. Do you want to try it out?

stasm commented 7 years ago

I was able to test the integration by manually triggering a build within the Travis UI: https://travis-ci.org/stasm/innerself/builds/278360298

bcruddy commented 7 years ago

@stasm I'm not sure if its just not showing up until someone pushes on an open PR but there's a repository settings to force CI to pass before merging (it can be overridden by admins)