Fantastic work on your first MDA Milestone, keep it up! Please see detailed feedback below, and let me know if you have any comments/questions:
General notes:
It is good practice to remove any installation code from your scripts; by keeping it there (install_packages()), you are re-installing the package each time that you run the code, and if someone else runs your script, it is making changes to their local machine by installing a package, which should never happen. Notice how it says ""type the following into the R terminal"".
Great work with exercise one, your code is mostly tidy and you justify your choices with explanations - however, I noticed that you respond to tasks 1.3 and 1.4 (which don't actually require any code) with an explanation written as a comment (using #) within a code chunk; no need to do this, you can just write it out as part of the document under the instruction! Only use code chunks when you are actually writing code and comments (using #) to comment on what the code is doing :)
In the first task you complete for Exercise 2, you assign a ggplot object to two vectors, but you don't actually print the output to screen - how else would you know what the plot looks like? Next time, make sure to print the object to screen so that the plot can be displayed. Same is true for your third task, when you're plotting the relationship between height and and years built! Also, as with your first exercise, you can save the in-code comments to explanations that describe what the code is doing, but you can write why you are interested in doing a given task / why it makes sense for your data outside of the code chunk. Along the same lines, your explanations as to why you chose those exercises for your data are a bit sparse, for next milestone try to reason why you would be interested (for example) in buildings that are 50 years or older - for instance, is that helping you answer a research question, do you expect those buildings to have more amenities (which is actually one of your research questions)...? With that said, you chose exercises that make a lot of sense for your dataset, and your code is clean and well written. Good job!
Your research questions are very thoughtful and you should be able to answer them using the dataset with a mix of data visualization and data exploration activities; I think that particularly the one where you want to find out whether newer buildings are more prone to not allow smoking is really interesting! I look forward to seeing how you approach those in your next milestone.
Tidy Submission: Great work, your repo is very neat and tidy. You knit your file to github_document which makes it easy to view from the website and is an appropriate format; however, the plots are not being rendered in your file because you also need to push the folder where images are stored that is automatically created in the local copy of your repo when you push to GitHub - please make sure to amend that for Milestone 1 and do it for next time too! Just a few minor comments: README could have some more context about the goal of this project; you do describe the files in the repo which is a great start. Also - no need to push your .Rproj to GitHub!
elza4125
commented
2 years ago
Hey Elizabeth,
Fantastic work on your first MDA Milestone, keep it up! Please see detailed feedback below, and let me know if you have any comments/questions:
github_documentwhich makes it easy to view from the website and is an appropriate format; however, the plots are not being rendered in your file because you also need to push the folder where images are stored that is automatically created in the local copy of your repo when you push to GitHub - please make sure to amend that for Milestone 1 and do it for next time too! Just a few minor comments: README could have some more context about the goal of this project; you do describe the files in the repo which is a great start. Also - no need to push your .Rproj to GitHub!Thanks, Icíar