Hey Elizabeth! Fantastic work and congratulations on finishing your last project for STAT545 - I hope you enjoyed the class and feel confident with your data analysis skills! Please let me know if you have any questions and don't hesitate to reach out. A few minor comments:
Tagged release: You tagged a release but made 14 more commits after that (i.e., your assignment wasn't actually done when you tagged the release, you should only tag it after all the work is done :)
Issues: This is not a requirement of the MDA and there are no deductions, but it is good practice to close issues when you are done with discussion (i.e., if you read the feedback and there is nothing that you would like to say / discussion has ended) - make sure to do that for future projects!
File and folder structure: Missing README files from all level 1 folders ("Every level-1 folder (that is, the ones stored in the top level, like “Milestone1” and “output”) has a README file, explaining in a sentence or two what is in the folder, in plain language (it’s enough to say something like “This folder contains the source for Milestone 1”). Also, I recommend that within each milestone folder you have (obviously no need to change it now, but for future work!) an "output" folder where you keep all the "unnamed-chunk-11-1.png" and etc figure files since then each level-1 folder looks neater.
Output: None of the plots are displaying in the knitted version of milestone 3 (deliverable3.md)
EX 2: Small deduction for Ex 2.2 because there is actually nothing under that exercise (no code or explanation of what you choose to produce; "Be sure to indicate in writing what you chose to produce"), I counted your summary(model1) under Ex 2.1 to answer the "Produce something relevant from your fitted model", but it's unclear.
EX 3: In Ex 3.2, you used saveRDS() to save the model, but you didn't use readRDS() after.
Hey Elizabeth! Fantastic work and congratulations on finishing your last project for STAT545 - I hope you enjoyed the class and feel confident with your data analysis skills! Please let me know if you have any questions and don't hesitate to reach out. A few minor comments:
summary(model1)
under Ex 2.1 to answer the "Produce something relevant from your fitted model", but it's unclear.saveRDS()
to save the model, but you didn't usereadRDS()
after.Best wishes, Icíar