search

statamic-rad-pack / mailchimp

Mailchimp integration for Statamic
https://statamic.com/addons/rad-pack/mailchimp
MIT License
18 stars 12 forks source link

Control panel save quirks #48

Closed websmyth closed 2 years ago

websmyth commented 3 years ago

Two small issues I’ve noticed:

1. Consent field 'consent_field' => 'consent', appears in mailchimp.php even if the user toggles consent off. I’d guess this wouldn’t happen if the user clears consent_field first, but haven’t tested that and it might not be obvious.

When the file saves like this, the CP config page loads without pulling in any of the data saved in mailchimp.php

2. Disable opt-in a) There’s no option to toggle this setting in the CP. b) When adding multiple forms, 'disable_opt_in' => false, only appears on the first form, not subsequent ones.

It would be useful to be able to toggle this in the CP on a per-form basis (I think that’s how the Statamic 2 version of this plugin worked?). Rare use case perhaps, but users with multiple audiences this may need to be toggled on/off per form.

edalzell commented 3 years ago

Thanks for this Dave, I'll get these sorted. In the meantime, setting the config in the file should work fine.

websmyth commented 3 years ago

All good! 🙌

edalzell commented 3 years ago

1. Consent field 'consent_field' => 'consent', appears in mailchimp.php even if the user toggles consent off. I’d guess this wouldn’t happen if the user clears consent_field first, but haven’t tested that and it might not be obvious.

I was unable to reproduce this, please try on the latest version (released soon) and let me know if this still occurs

edalzell commented 3 years ago

2. Disable opt-in a) There’s no option to toggle this setting in the CP. b) When adding multiple forms, 'disable_opt_in' => false, only appears on the first form, not subsequent ones.

It would be useful to be able to toggle this in the CP on a per-form basis (I think that’s how the Statamic 2 version of this plugin worked?). Rare use case perhaps, but users with multiple audiences this may need to be toggled on/off per form.

This will be in the next release.

websmyth commented 3 years ago

Amazing. Will confirm 1, too. 🙌

edalzell commented 3 years ago

2. Disable opt-in a) There’s no option to toggle this setting in the CP. b) When adding multiple forms, 'disable_opt_in' => false, only appears on the first form, not subsequent ones. It would be useful to be able to toggle this in the CP on a per-form basis (I think that’s how the Statamic 2 version of this plugin worked?). Rare use case perhaps, but users with multiple audiences this may need to be toggled on/off per form.

This will be in the next release.

In 2.3.1

edalzell commented 2 years ago

Closing due to lack of confirmation.

Please re-open if still an issue.