search

statamic-rad-pack / mailchimp

Mailchimp integration for Statamic
https://statamic.com/addons/rad-pack/mailchimp
MIT License
18 stars 12 forks source link

Access level to Edalzell\Mailchimp\ServiceProvider::bootConfig() must be protected or weaker #92

Closed benfurfie closed 1 year ago

benfurfie commented 1 year ago

What is happening? When attempting to install the Mailchimp addon via composer running the command composer require silentz/mailchimp into a v4 install of Statamic, you get the error:

Access level to Edalzell\Mailchimp\ServiceProvider::bootConfig() must be protected (as in class Statamic\Providers\AddonServiceProvider) or weaker

This impacts both fresh installs and v2/3 upgrades.

What should be happening? The composer installer should complete without errors.

Did you RTFM? Yes, Erin. I RTFM'd. 😂

How to reproduce

  1. Run composer create-project statamic/statamic demo
  2. cd into demo
  3. Run composer install to ensure all default composer packages install correctly.
  4. Run composer require silentz/mailchimp.
  5. See the error during package discovery.

Environment Statamic: 4.1 and Statamic 4.0 PHP: 8.1

edalzell commented 1 year ago

Thanks Ben, I'll get a release out this weekend.

I'm surprised it worked at all as I haven't released a v4 compatible version yet.

@benfurfie do you use the marketing permissions part? I ask because the Spatie package I use underneath dropped support for it.

benfurfie commented 1 year ago

@edalzell – not that I'm aware of. I'll double check with the rest of the team.

edalzell commented 1 year ago

Closing in favour of #93