search

statamic-rad-pack / mailchimp

Mailchimp integration for Statamic
https://statamic.com/addons/rad-pack/mailchimp
MIT License
19 stars 13 forks source link

Statamic 4 #93

Closed duncanmcclean closed 1 year ago

duncanmcclean commented 1 year ago

We chatted about this on Discord but thought I'd create an issue in case you forget (because I know I do without an issue) about adding Statamic 4 support.

We're planning out Statamic 4 upgrades for our sites at the moment, this addon is a blocker for one of our sites (however, we have no massive rush on our end right now in upgrading)

edalzell commented 1 year ago

Hey @robdekort can you try this PR? It's on the fix/support-v4 branch.

You'd put dev-fix/support-v4 as the constraint in your composer.json.

Note that I took out the GDPR Permissions thing cuz the Spatie package I use doesn't support it any more. I'll add it back in a bit, if this works.

robdekort commented 1 year ago

Hey @edalzell. Much appreciated. I'm getting an error about the mailchimp assets missing.

Note: I don't use the GDPR stuff from Mailchimp.

edalzell commented 1 year ago

Hey @edalzell. Much appreciated. I'm getting an error about the mailchimp assets missing.

Note: I don't use the GDPR stuff from Mailchimp.

OH right, sorry @robdekort, you'll need to symlink those in.

1) remove the existing ones (if they exist), rm -rf public/vendor/mailchimp 2) symlink in the new ones, ln -s vendor/silentz/mailchimp/dist public/vendor/mailchimp

That should do it.

robdekort commented 1 year ago

Hmmm the vendor/silentz/mailchimp/dist directory is empty.

robdekort commented 1 year ago

I was able to compile them.

robdekort commented 1 year ago

Ok cool. I was able to subscribe to a mailchimp newsletter via the addon. That seems to work :-).

edalzell commented 1 year ago

Ok cool. I was able to subscribe to a mailchimp newsletter via the addon. That seems to work :-).

Perfect, I'll get a release out today

robdekort commented 1 year ago

Neat

edalzell commented 1 year ago

@robdekort @duncanmcclean please use 3.0.1, 3.0 was a broken release.

robdekort commented 1 year ago

Wonderful Erin. Thanks. Updating the remainder of my sites right now.

robdekort commented 1 year ago

Hey Erin,

I'm still running into issues with those darned assets. I don't understand any of that system tbh. Anyways. I'm getting this:

INFO Publishing [mailchimp] assets.

ERROR Can't locate path: <vendor/silentz/mailchimp/resources/dist/build/>.

robdekort commented 1 year ago

I think the resources/ part shouldn't be in that path.

edalzell commented 1 year ago

Hey Erin,

I'm still running into issues with those darned assets. I don't understand any of that system tbh. Anyways. I'm getting this:

INFO Publishing [mailchimp] assets.

ERROR Can't locate path: <vendor/silentz/mailchimp/resources/dist/build/>.

Fixed in 3.0.2, sorry about that.