statamic / cms

The core Laravel CMS Composer package
https://statamic.com
Other
3.89k stars 520 forks source link

Warming stache during deploy outputs many messages #10224

Closed edalzell closed 4 months ago

edalzell commented 4 months ago

Bug description

We call please stache:refresh during deployment, and since we upgraded to v5 we see hundreds of these messages on every deploy:

image

(same with Warming the State)

How to reproduce

Use Forge to deploy a v5 and have please stache:refresh as part of the deploy.

Logs

No response

Environment

Environment
Application Name: Statamic
Laravel Version: 11.9.1
PHP Version: 8.3.7
Composer Version: 2.7.6
Environment: local
Debug Mode: ENABLED
URL: transform.test
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: NOT CACHED

Drivers
Broadcasting: null
Cache: statamic
Database: sqlite
Logs: stack / daily, front
Mail: log
Queue: sync
Session: file

Livewire
Livewire: v3.5.0

Statamic
Addons: 13
Sites: 1
Stache Watcher: Enabled
Static Caching: Disabled
Version: 5.6.0 PRO

Statamic Addons
aryehraber/statamic-captcha: 1.11.0
edalzell/forma: 3.0.1
jacksleight/statamic-bard-mutator: 2.3.1
jacksleight/statamic-distill: 0.7.0
jonassiewertsen/statamic-jobs: 1.5.0
jonassiewertsen/statamic-livewire: 3.3.1
statamic/seo-pro: 6.0.3
transformstudios/events: 5.4.3
transformstudios/front: dev-fix/to-data
transformstudios/github: dev-main
transformstudios/review: 5.0
transformstudios/simple: 5.0.0
transformstudios/uptime: dev-fix/front

Installation

Fresh statamic/statamic site via CLI

Additional details

No response

stanbridge-wcorrea commented 4 months ago

I'm facing issues after v5 with the static cache too, in my case the static folder is not being created. Can you check if yours is there after deployment?

Also, I didn't have the stache refresh command as a part of my deployment script, but I will add it and will let you know.

jasonvarga commented 4 months ago

This issue is due to Prompts. Every frame change of the spinner next to the Clearing the stache... message is being rendered as a new line.

edalzell commented 4 months ago

I'm facing issues after v5 with the static cache too, in my case the static folder is not being created. Can you check if yours is there after deployment?

Also, I didn't have the stache refresh command as a part of my deployment script, but I will add it and will let you know.

That is unrelated, I'm only warming the stache, this is nothing to do with the static cache, sorry.

edalzell commented 4 months ago

Clearing the stache

I guess we could not spin?

CleanShot 2024-05-29 at 14 48 48@2x

jasonvarga commented 4 months ago

I added an issue on Prompts.

https://github.com/laravel/prompts/issues/151

jasonvarga commented 4 months ago

See the response here: https://github.com/laravel/prompts/issues/151#issuecomment-2145232870

I'd recommend adding the --no-progress or --no-ansi options.