CP: Update badge on up to date site

marcorieser commented 3 months ago

Bug description

Sometimes the changelog for an addon does not get updated which causes an update badge in cp even if everything is up to date. In my case it's the Translation Manager addon. But found an issue that seems like to underline my case: https://github.com/statamic/cms/issues/6718

How to reproduce

No idea but installing the Translation Manager addon probably reproduces the issue atm.

Logs

No response

Environment

Environment
Application Name: Wizard Live
Laravel Version: 11.10.0
PHP Version: 8.3.7
Composer Version: 2.7.6
Environment: local
Debug Mode: ENABLED
URL: statamic-wizard-promotions.test
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: statamic
Database: sqlite
Logs: stack / single
Mail: log
Queue: sync
Session: file

Livewire
Livewire: v3.5.0

Statamic
Addons: 5
Sites: 2 (German, English)
Stache Watcher: Enabled
Static Caching: Disabled
Version: 5.7.2 PRO

Statamic Addons
jonassiewertsen/statamic-livewire: 3.4.0
marcorieser/statamic-vitals: 1.2.0
marcorieser/tailwind-merge-statamic: 1.1.0
ryanmitchell/statamic-translation-manager: 2.0.0
stillat/relationships: 2.2.0

Installation

Fresh statamic/statamic site via CLI

Additional details

No response

marcorieser commented 3 months ago

Just noticed that the version on statamic.com is outdated for the addon (1.6.0 instead of 2.0.0): https://statamic.com/addons/thoughtco/translation-manager

marcorieser commented 3 months ago

According to Rob, releasing a new version of the addon fixes the issue. Probably because that re-pings (or something) the version update and Statamic can pick it up.

robdekort commented 3 months ago

According to Rob, releasing a new version of the addon fixes the issue. Probably because that re-pings (or something) the version update and Statamic can pick it up.

That's true. Perhaps a resave of the addon on statamic.com might also trigger something. Not sure how stuff works, but perhaps it's an issue on statamic.com and not the CMS.

duncanmcclean commented 3 months ago

We've just deployed a fix to Statamic.com which should hopefully prevent this issue from happening in future.

For addons affected by this issue, the addon developer should be able to trigger a re-sync of the product on Statamic.com by resaving their latest release (just edit and re-save, no actual changes are required).

After that, the product's information should be up-to-date within a minute or two.

robdekort commented 3 months ago

Nice. And that’s good to know. I’ll keep an eye out.

robdekort commented 3 months ago

Notice I'm still seeing this in the latest version. You can see Statamic believes Forma isn't up2date.

marcorieser commented 3 months ago

Notice I'm still seeing this in the latest version. You can see Statamic believes Forma isn't up2date.

Has the dev of Forma re-triggered the sync as Duncan mentioned above?

robdekort commented 3 months ago

Has the dev of Forma re-triggered the sync as Duncan mentioned above?

I don't know, I'm not @edalzell. But I think the fix doesn't work:

We've just deployed a fix to Statamic.com which should hopefully prevent this issue from happening in future.

robdekort commented 3 months ago

Ah, the latest release from Forma was before the fix. Gotcha.

@edalzell: would you trigger a save on statamic.com like this: "For addons affected by this issue, the addon developer should be able to trigger a re-sync of the product on Statamic.com by resaving their latest release (just edit and re-save, no actual changes are required)."

edalzell commented 3 months ago

@edalzell: would you trigger a save on statamic.com like this: "For addons affected by this issue, the addon developer should be able to trigger a re-sync of the product on Statamic.com by resaving their latest release (just edit and re-save, no actual changes are required)."

Done.

robdekort commented 3 months ago

Thanks Erin.

Unfortunately this issue doesn’t seem solved then.

Screenshot 1	Screenshot 2

robdekort commented 3 months ago

I cleared the caches btw.

duncanmcclean commented 3 months ago

Thanks! We'll need to take another look.

robdekort commented 2 months ago

It seems to be getting a bit worse even 😬

robdekort commented 2 months ago

Even weirder, I just updated Statamic Peak SEO to 8.15.3, and the badge increases again. This is not good for my badge OCD ;-).

robdekort commented 2 months ago

Just found out if you run statamic new badge-galore studio1902/statamic-peak you can reproduce a fresh straight up lying in your face update badge. It thinks the Tools and Commands addons are out of date.

robdekort commented 2 months ago

This is driving me bonkers so I did something that seem to have helped. For the two troubled addons I did the following to get rid of the badges:

Tagged and released a new version
Ran composer update
Pulled the releases on github
Trashed the tags using git push --delete origin vX.X.X
Trashed the releases on packagist.org
Ran composer update

robdekort commented 2 months ago

Editing a faulty release on github.com seems to trigger something as well. Then updating the page on statamic.com fixed stuff.

duncanmcclean commented 1 month ago

After some troubleshooting, it seems like GitHub isn't sending webhooks when releases are tagged, which is leading Statamic.com to be out-of-date, which subsequently causes the badge in the CP even when you're on the latest version.

I've submitted a support ticket with GitHub. Hopefully they'll have some ideas. 😄

duncanmcclean commented 1 month ago

We've just deployed some changes to Statamic.com, which should (hopefully 🤞) prevent this issue from happening in the future.

For any addons already affected, the addon developer can trigger a sync by re-saving their product on the Marketplace. Then, within a few minutes, the product's information (including releases) should be up-to-date.

robdekort commented 1 month ago

Oh Duncan you wonderful man! I just tested on a few sites and it seems all good now. Might be able to tick this one off.

duncanmcclean commented 1 month ago

Great!

I'm going to close this issue now. If anyone's still seeing the update badge when it shouldn't be showing...

If the addon's latest release was tagged before we deployed our fix yesterday, the addon developer will need to re-save their addon on the Marketplace in order to force Statamic.com to sync with GitHub.
If the addon's latest release was tagged after we deployed our fix yesterday, it probably means the issue is back 😞. In which case, please leave a comment on this issue and we can take a look.

robdekort commented 2 weeks ago

If the addon's latest release was tagged after we deployed our fix yesterday, it probably means the issue is back 😞. In which case, please leave a comment on this issue and we can take a look.

Afraid to inform ya that this issue is still a thing.

duncanmcclean commented 2 weeks ago

Oh no! 😞

We'll need to take another look when we get a chance.

statamic / cms