statamic / cms

The core Laravel CMS Composer package
https://statamic.com
Other
4.11k stars 538 forks source link

[5.x] Prevent comma completing tags when defining container validation rules #11132

Closed duncanmcclean closed 1 week ago

duncanmcclean commented 1 week ago

This pull request fixes an issue with the Taggable fieldtype when it's used for defining an asset container's validation rules, where a comma in a rule completes the tag, which can be frustrating in the context of validation rules.

Fixes #11122.

jasonvarga commented 1 week ago

Thanks but I think the actual solution should be to bring the validation ux over from the field settings. The use of a taggable fieldtype here was just a quick fix.

The validation field could be extracted to a fieldtype and then used in both places.