search

statamic / cms

The core Laravel CMS Composer package
https://statamic.com
Other
4.11k stars 538 forks source link

[5.x] Ensure file cacher honors allow/disallow query string configs #11143

Closed ryanmitchell closed 6 days ago

ryanmitchell commented 6 days ago

This PR updates the file cacher to respect the allow/disallow query string params. As it was using its own getUrl() function these were being ignored.

I cant think of any reason why they should be... maybe I'm missing something.

Closes https://github.com/statamic/cms/pull/11143

ryanmitchell commented 6 days ago

Was meant to link to https://github.com/statamic/cms/issues/11142 - and closed cause we realised it was done for a reason.

Chatted to Duncan and this could still work but it would mean Nginx/Apache wouldnt get the HTML directly but it would be served by Statamic - so still faster, but not quite full cache fast.

Anyway, I closed it cause of what Jason said in his original PR comments