Revision Group Day doesn't respect the Moment Locale

statamic / cms

The core Laravel CMS Composer package

https://statamic.com

Other

3.71k stars 508 forks source link

Revision Group Day doesn't respect the Moment Locale #2508

Closed helloDanuk closed 8 months ago

helloDanuk commented 3 years ago

Bug Description

…Labels in the History

UNPUBLISH
PUBLISH
REVISION

…and the date format is not yet localized (bold title, 'September 18, 2020' in the screenshot). Same problem as in #2053.

Environment

Statamic 3.1.1 Pro Laravel 8.34.0 PHP 7.4.16

Install method (choose one):

Fresh install from statamic/statamic

github-actions[bot] commented 3 years ago

This issue has not had recent activity and has been marked as stale — by me, a robot. Simply reply to keep it open and send me away. If you do nothing, I will close it in a week. I have no feelings, so whatever you do is fine by me.

helloDanuk commented 3 years ago

💨🤖

jasonvarga commented 3 years ago

The dates seem to be translated fine.

helloDanuk commented 3 years ago

The format in german is different. It should be:

Mai 2021

Am 18.05.2021 um 23:31 schrieb Jason Varga @.***>:

The dates seem to be translated fine.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jasonvarga commented 3 years ago

It still says Mai though, not May.

jasonvarga commented 3 years ago

Nevermind, I was able to get it to work how you're expecting. 👍

helloDanuk commented 3 years ago

Yup, it was a bit unclear, sorry. The translation were fine, the issue was only the format. Thanks!

helloDanuk commented 1 year ago

If you start a brand new site with 4.22 and change the locale to de_CH, it looks like the relative date of a single revision is now in English. This was originally translated correctly, see screenshot at the top. Or am I missing a setting in the config area?