Git Integration: Wrong Commit Message

aerni commented 3 years ago

Bug Description

Super nitpicking but here you go … When saving an entry from a collection named pages, the commit message reads Collection saved rather than Entry saved like with all other collections.

How to Reproduce

Enable the Git Integration
Save an entry from a pages collection
Save an entry from another collection
Compare the commit messages

Environment

Statamic 3.0.30 Pro Laravel 8.16.0 PHP 7.4.12 aerni/social-links 2.1.0 aerni/zipper 1.2.0 jonassiewertsen/statamic-livewire 2.1.2 spatie/statamic-responsive-images 1.4.0 visuellverstehen/statamic-classify 2.0.0

duncanmcclean commented 3 years ago

I can confirm this issue, it's happening on some of my sites too. See doublethreedigital/sc-docs.doublethree.digital #503fd4d

I imagine this is quite an easy one to fix. Should be in resources/lang/en somewhere.

jesseleite commented 3 years ago

@damcclean Not related to a language file. I think this is due to how multiple changes are saved at once (entry, as well as collection's tree), then git add {{ paths }} is run, adding both paths at once and committing with the CollectionSaved event's message first. Think I have an idea how to fix this though.

aerni commented 3 years ago

Still an issue.

statamic / cms