statamic / cms

The core Laravel CMS Composer package
https://statamic.com
Other
4.08k stars 533 forks source link

Button label when saving Navigation item #8060

Closed espenlg closed 1 year ago

espenlg commented 1 year ago

Bug description

Not a bug, but when looking at the norwegian translation on this button it's just wrong. I could change the translation, but the reason it is wrong is related to the word "Submit". Should/could this be changed to "Save" instead?

Screenshot 2023-05-04 at 23 58 24

How to reproduce

Edit a navigation item.

Logs

No response

Environment

Environment
Application Name: Properti Stage
Laravel Version: 9.52.5
PHP Version: 8.0.28
Composer Version: 2.5.5
Environment: local
Debug Mode: ENABLED
URL: properti-stage.test
Maintenance Mode: OFF

Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED

Drivers
Broadcasting: log
Cache: statamic
Database: mysql
Logs: stack / single
Mail: smtp
Queue: sync
Session: file

Statamic
Addons: 6
Antlers: runtime
Stache Watcher: Enabled
Static Caching: Disabled
Version: 3.4.8 PRO

Statamic Addons
aryehraber/statamic-captcha: 1.9.1
properti/estate-items-import: dev-main
properti/properti-dashboard: dev-main
r8edge/imagemap: dev-main
r8edge/welcome-widget: dev-main
statamic/eloquent-driver: 1.2.0

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

runtime (new)

Additional details

No response

jasonvarga commented 1 year ago

The button label says Submit in English and Send in Norwegian.

CleanShot 2023-05-29 at 14 13 32

You contributed the translation of that.

CleanShot 2023-05-29 at 14 15 16

Feel free to update the translation.

espenlg commented 1 year ago

@jasonvarga My question was - why is the word "Submit" used here and not "Save"? When you complete a form you submit the form - like pass it on to the next step / handler. Save/Add etc would make more sense, and in the rest of CP the word "Save" is widely implemented.

jasonvarga commented 1 year ago

It's not saving there. It's only actually gets saved when you save the entire navigation.

espenlg commented 1 year ago

Good point. What about Apply? Like when you add a fieldset to a blueprint?