statamic / cms

The core Laravel CMS Composer package
https://statamic.com
Other
4.05k stars 530 forks source link

Addons page does not list addons with minimum Statamic version of 4.0 #8166

Closed jacksleight closed 1 year ago

jacksleight commented 1 year ago

Bug description

I mentioned something related to this in a support ticket but I've had some time to look at it properly now.

The addons page in the CP (both All and Installed tabs) is not listing any addons with a minimum Statamic version of 4.0. However the installed tab at the top does show the correct number of installed addons.

This seems to be because of this line in AddonsQuery:

'filter' => ['statamic' => 3],

Changing that to 4 makes them appear, however then any addons with a minimum version of 3.x (that also support 4.0) disappear instead.

How to reproduce

Logs

No response

Environment

Statamic
Addons: 1
Antlers: runtime
Stache Watcher: Disabled
Static Caching: Disabled
Version: 4.1.3 Solo

Installation

Fresh statamic/statamic site via CLI

Antlers Parser

None

Additional details

No response

robdekort commented 1 year ago

giphy

My Addons CP page is very sad indeed.

robdekort commented 1 year ago

I could totally live without this page altogether btw. You need composer anyways to install addons.

joshuaDclark commented 1 year ago

Reaching out on what may be a similar issue. The Updates page in CP does not show the updated version of addon packages even after they were updated.

Confirmed packages were updated based on changes in the updates.

Uploading a screenshot for reference. Could this possibly be a Statamic UI issue?

updates

jasonvarga commented 1 year ago

@joshuaDclark Can you post the output of this command?

composer show -D | grep peak
joshuaDclark commented 1 year ago

@joshuaDclark Can you post the output of this command?

composer show -D | grep peak

@jasonvarga

studio1902/statamic-peak-browser-appearance v3.2 studio1902/statamic-peak-commands v2.3.3 studio1902/statamic-peak-seo v6.0 studio1902/statamic-peak-tools v3.2

jasonvarga commented 1 year ago

@joshuaDclark I've updated something on statamic.com for that. Try clearing your cache then running php please addons:discover.

joshuaDclark commented 1 year ago

@jasonvarga Thanks. I tried this and now I can see what is up to date in CP. However it appears it unlisted some of the PEAK addons. I'm also still seeing a notification flag to the left of the Updates tab in the left hand column within CP indicating that there are 3 updates available.

jasonvarga commented 1 year ago

Screenshot?

joshuaDclark commented 1 year ago

updates_2

jasonvarga commented 1 year ago

Those should be fixed now. It was an issue with some data on the statamic.com side.

(@robdekort The "Minimum Git Version" for those were set to v1.0 - changing to 1 fixed it. We'll improve validation there.)

robdekort commented 1 year ago

Thanks Jason, I’ll look into that!

robdekort commented 1 year ago

Hey Jason. I see you changed all them for my addons. Thanks. But the initial issue still seems open. They're not listed in the addons tab, and you also can't search for v4+ addons.

robdekort commented 1 year ago
Screenshot 2023-08-23 at 10 46 36 Screenshot 2023-08-23 at 10 46 27
jasonvarga commented 1 year ago

The pr hasn't been released yet.

robdekort commented 1 year ago

Ahhh sorry! Mistaken :) completely missed that pr

robdekort commented 1 year ago

Yup. All good now!