search

statamic / ideas

💡Discussions on ideas and feature requests for Statamic
https://statamic.dev
31 stars 1 forks source link

Make the CSV export delimiter adjustable #891

Closed theLeroy closed 1 year ago

theLeroy commented 1 year ago

Statamic uses a comma as a delimiter in the CSV export. This is hardcoded at the moment. This is not nice for example in Switzerland / Europe, because in these countries Excel expected a semicolon by default, and so you always have to convert it.

Our proposal now would be that we make a pr which implements the adaptability in the settings. Maybe under: config -> statamic -> system?

It would be easy to give the exporter (League CSV) the setting.

Code of the exporter: https://github.com/statamic/cms/blob/3.3/src/Forms/Exporters/CsvExporter.php

Before we put the work in, what would you think of such a PR?

jasonvarga commented 1 year ago

Perfectly fine with a config setting that passes along to the setDelimiter method!

theLeroy commented 1 year ago

pr https://github.com/statamic/cms/pull/6964