Translations not working

statamic / seo-pro

An all-in-one site reporting, metadata wrangling, Open Graph managing, Twitter card making, sitemap generating, turn-key addon for Statamic.

https://statamic.com/addons/statamic/seo-pro

53 stars 36 forks source link

Closed justkidding96 closed 1 year ago

justkidding96 commented 1 year ago

Hi I've facing a problem with the translation see screenshot below. What can I do to fix this issue?

j-jalving commented 1 year ago

I have the same issue. Any word on this?

jesseleite commented 1 year ago

@justkidding96 @j-jalving Can we see what you both have configured for your locale and fallback_locale in config/app.php here?

j-jalving commented 1 year ago

Both are set to nl. But the problem is simply that the dutch translation files aren't complete.

jasonvarga commented 1 year ago

That makes sense then. If fallback_locale was en, you'd at least see English words rather than the translation keys.

In that case we'd accept a PR to fill out the missing translations. We don't speak Dutch so we rely on third party translation contributions.

Thanks!

j-jalving commented 1 year ago

I created a pull requests with the updated Dutch translations: #284

j-jalving commented 1 year ago

Found out this weird issue when my CP language is set to Dutch and my locale is also set to nl and my fallback_locale to en:

Overview page This one falls back to english like it should:

Scan page This one falls back does not fall back (the english strings seem to be present in the translation file though) :

Also, when can we expect the new nl translations to be published to Packagist?

jasonvarga commented 1 year ago

Tagged now. Excuse the delay.