Fix `array_merge()` error when parsing Antlers

statamic / seo-pro

An all-in-one site reporting, metadata wrangling, Open Graph managing, Twitter card making, sitemap generating, turn-key addon for Statamic.

https://statamic.com/addons/statamic/seo-pro

52 stars 34 forks source link

Fix `array_merge()` error when parsing Antlers #253

Closed o1y closed 1 year ago

o1y commented 1 year ago

Fixes #252

jesseleite commented 1 year ago

Hey thank you for the PR, but curious...

We're noticing that this suppresses the PHP error, but the generated SEO meta is still all borked. For example:

CleanShot 2023-01-09 at 17 07 56

The reason for this is because you don't have a home page at a url of /, so it can't find default values to fall back on. Does your site not have a / home page?

o1y commented 1 year ago

I see the problem. When using custom routes as described in the Ticket, there is no home site / anymore. Then my PR is not fixing the issue. Sorry 🙃