statamic / seo-pro

An all-in-one site reporting, metadata wrangling, Open Graph managing, Twitter card making, sitemap generating, turn-key addon for Statamic.
https://statamic.com/addons/statamic/seo-pro
53 stars 36 forks source link

Generate report job takes too long #262

Closed stuartcusackie closed 9 months ago

stuartcusackie commented 1 year ago

My reports won't complete on a site with 400 entries. I am using the Redis queue with Horizon at the default of 60 second timeouts:

image

I think ideally these jobs should be split (one entry per job). A job that takes 10 minutes to run seems like a bad idea, and this site isn't really that big compared to some.

If that's not happening then a simpler improvement would be a customisable queue in the config. At the moment the only option is to massively increase the timeout of all jobs on the default queue, which I don't like doing.

Thanks!

stuartcusackie commented 1 year ago

I have increased all jobs to 120 seconds and still it fails: image

I have now increased jobs to 300 seconds and it still looks like it is going to fail. image

rubzie commented 11 months ago

We're experiencing comparable issues, hope it can be addressed! 🙏🏼

jesseleite commented 9 months ago

@stuartcusackie @rubzie, some pretty big performance improvements coming in the next release https://github.com/statamic/seo-pro/pull/304 and https://github.com/statamic/seo-pro/pull/307, with more improvements yet to come...

My reports won't complete on a site with 400 entries

For example, I'm now generating a report for 1000 entries, without a queue even set up, in ~8.5 seconds...

CleanShot 2023-12-12 at 16 35 33

rubzie commented 9 months ago

@stuartcusackie @rubzie, some pretty big performance improvements coming in the next release #304 and #307, with more improvements yet to come...

Wooohoo nice, looking forward to it, thanks a lot @jesseleite! Then onto the next challenge, making SEO Pro work for multi site ;)

jesseleite commented 9 months ago

Will close this when we tag next version, but see https://github.com/statamic/seo-pro/pull/310 🏎️

jesseleite commented 9 months ago

Tagged 5.4.0 🤘