search

statamic / seo-pro

An all-in-one site reporting, metadata wrangling, Open Graph managing, Twitter card making, sitemap generating, turn-key addon for Statamic.
https://statamic.com/addons/statamic/seo-pro
53 stars 36 forks source link

Container-ize `SiteDefaults` #298

Closed ryanmitchell closed 10 months ago

ryanmitchell commented 11 months ago

As discussed on Discord this PR container-izes SiteDefaults, allowing developers to override its methods, eg

            $this->app->bind(\Statamic\SeoPro\SiteDefaults::class, \App\MySiteDefaults::class);

My use case is storing the data in a database rather than a flat file by overloading the save and getDefaults methods.

jesseleite commented 10 months ago

Closed in favour of a slightly simpler implementation in #302. Thanks as always for the rad PRs! ❤️