search

statamic / spock

Automatically perform git commits, pushes, and other cli actions when Statamic content changes
95 stars 16 forks source link

Asset Changes not detected by Spock #34

Closed PhilJ closed 4 years ago

PhilJ commented 5 years ago

I can confirm the issue reported by Waze:

Spock is not getting notified about asset changes and is therefore not able to commit them. We also added an manual workaround similary to @wanze.

However, sSince this is throwing errors on every failed commit it would be great if this could be fixed. We are using Statamic 2.11.5and Spock 2.1.0.

Originally posted by @wanze in https://github.com/statamic/spock/issues/24#issuecomment-447334083 :

I am also running into this issue using the following setup:

Ignored events:

  - Statamic\Events\Data\AssetUploaded
  - Statamic\Events\Data\AssetMoved
  - Statamic\Events\Data\AssetDeleted
  - Statamic\Events\Data\FileUploaded

My current solution is to use a custom after command:

- if (( $(git status -s | wc -l) > 0 )); then git add --all && git commit -m "[skip-ci] Additional changes after running Spock" && git push; fi
jesseleite commented 5 years ago

Sorry for the delay. Hmm, I couldn't reproduce @wanze's issue either. How is your asset container configured?

goldnead commented 4 years ago

Sorry for not responding since then. Our Issue got resolved somehow. With Statamic 2.11.3 and Spock 2.2.2 those Events get properly handled. You can close this Issue npw :)