Restore view hints on every iteration...

statamic / ssg

The official Statamic Static Site Generator

233 stars 24 forks source link

Restore view hints on every iteration... #119

Closed tao closed 1 year ago

tao commented 1 year ago

AddViewPaths Middleware adds paths for each site, which compounds on every iteration. By resetting we no longer get the compounding issue. Fixes #116.

what-the-diff[bot] commented 1 year ago

Added a new protected property called $viewHints
Created backupViewHints() method to store the view hints in the newly created property
Modified restoreViewPaths() and added restoreViewHints(). These methods are used when generating content files for each page, so that we can reset them after every iteration of pages (otherwise it will use whatever was set last).

jasonvarga commented 1 year ago

I think this is a good fix, but it should probably be done on the cms side. I will get this sorted out. Thanks!

jasonvarga commented 1 year ago

Replaced by statamic/cms#7030

tao commented 1 year ago

Thanks