search

statamic / ssg

The official Statamic Static Site Generator
229 stars 23 forks source link

Bugfix/remove shuffle #135

Closed simonhamp closed 11 months ago

simonhamp commented 1 year ago

The shuffle function seems to cause index pages of paginated collections to randomly take the view of one of the later pages in the resultset.

It probably needs further digging to understand why the wrong page is being substituted, but simply removing the shuffle seems to solve it for now.

jesseleite commented 11 months ago

Thanks for the PR! That shuffle() though, was very intentional for reasons mentioned in https://github.com/statamic/ssg/pull/57.

We're also thinking that removing the shuffle only fixed this for you coincidentally, and that if there's a problem with a view leaking from one page to another, there's likely a more intentional fix required. Worth looking into, but going to close this one for now.

Feel free to create an issue with steps to reproduce, or even a example repo, if possible ❤️