statamic / v2-hub

Statamic 2 - Feature Requests and Bug Reports
https://statamic.com
95 stars 5 forks source link

The 'user.registering' event doesn't return errors added by addons #2514

Open aryehraber opened 4 years ago

aryehraber commented 4 years ago

I'm adding Recaptcha support for Statamic's user registration form by listening to the 'user.registering' event. On failure, I return errors which are captured by the runRegisteringEvent() method which in turn passes the MessageBag back to the register() method... so far so good!

The registration form correctly stops further processing and returns back, however the errors aren't available inside {{ errors }}.

Solution:

The issue is line 178 of the UserListener class:

return back()->withInput()->withErrors($errors);

The withErrors method is missing the errors key:

return back()->withInput()->withErrors($errors, 'userRegister');

By adding this key (also used by the registration validator on line 168), I'm able to correctly receive and render the error inside templates.

alehandrof commented 4 years ago

Is this still an issue?