search

statbiophys / soNNia

GNU General Public License v3.0
13 stars 4 forks source link

Fixed joint feature loading. Sped up feature extraction. Removed redundant for loops. Adding typing. #3

Closed zacmon closed 9 months ago

zacmon commented 9 months ago

This pull request's main purpose was to fix line 279 to correct the non-homogeneous numpy array that ensued from using joint features, in my experience. Additionally, I added typing for documentation purposes, formatted code to be more legible, and streamlined find_seq_features and _load_features_and_model by removing for loops and using more efficient functions. I tested this version of SoNNia compared to the current release, and the Q's correlated to 0.9998, so everything should be the same there.

giulioisac commented 9 months ago

Have you added these changes to the single branch too? We are going to get rid of the main soon.

zacmon commented 9 months ago

These changes were all added to the single branch. This pull request is now moot.