search

statdivlab / corncob

Count Regression for Correlated Observations with the Beta-binomial
102 stars 22 forks source link

CRAN problem fixes #142

Closed david-barnett closed 1 year ago

david-barnett commented 1 year ago

Hi @bryandmartin

Thanks for the great package. This pull request attempts to fix the problems that appear to have caused corncob's removal from CRAN.

The main problem appears to be caused by the cran release of detectseparation version 0.3 which changes the name of one of the elements in the list returned by detect_separation.

I ran devtools::check on my machine, and addressed another couple of warnings and notes too, in separate commits. Hope this helps to get corncob back on cran 🙂

cheers, David

david-barnett commented 1 year ago

141 apparently related issue, just spotted this now

bryandmartin commented 1 year ago

@david-barnett Thank you so much for this wonderful pull request! Just reviewed it and will be merging now.