search

statdivlab / corncob

Count Regression for Correlated Observations with the Beta-binomial
102 stars 22 forks source link

Output models despite unable to converge #145

Closed jorondo1 closed 6 months ago

jorondo1 commented 1 year ago

Hi, Is there a way to save a differentialTest output even if no models converge? We'd be interested to report the absence of significant taxa in the effects we are looking at, and having some numbers to support that.

Cheers!

svteichman commented 10 months ago

Hi @jorondo1,

What kind of output are you interested in? What numbers to support the absence of significant taxa would be helpful?

Best, Sarah

adw96 commented 6 months ago

@svteichman Since normally "no models converged" indicate a coding issue, didn't we update corncob so that it prints out the error message for the first failed model?

If so, I think it's okay to close this issue -- given inactivity AND that we have more helpful error messages now.

svteichman commented 6 months ago

Yes, since this issue was posted we've updated corncob to give error messages to help figure out why no models successfully converged. I suspect that it is fairly uncommon for all models to fail to converge for a call to corncob without coding errors.