statdivlab / corncob

Count Regression for Correlated Observations with the Beta-binomial
102 stars 22 forks source link

`contrastsTest` returns NULL for all return values #160

Closed svteichman closed 9 months ago

svteichman commented 10 months ago

I believe there is a problem with the use of the function limma::makeContrasts() called by the helper function waldchisq_test() when running contrastsTest(). There are two issues that I see:

I have currently added a warning to the contrastsTest() function that behavior is not as expected but I think this should be looked at in more detail.

adw96 commented 10 months ago

Good catch!

If I recall correctly, statdivlab/rigr has a way to test contrasts. If we can turn a limma dependency into a rigr dependency, that would give us more control over failures.

Also, #$*& CRAN for removing all of these foundational packages!

svteichman commented 9 months ago

It turns out the function works for and the examples/tests for this function weren't working. They've been fixed in PR #165 so I'm closing this issue.