statdivlab / corncob

Count Regression for Correlated Observations with the Beta-binomial
103 stars 22 forks source link

Resolving warnings and notes from PR #159 #163

Closed svteichman closed 1 year ago

svteichman commented 1 year ago

Resolving warnings and notes from PR #159

Avoid notes/warnings about optimr by removing it fully from the package - now if the user wants to do optimization with BFGS instead of trust and does not have optimx installed, they will get an error suggesting they install it.

Avoid note about .data being an undefined global variable by adding an importFrom rlang .data in the documentation for plot.bbdml().

Trying to resolve the note about the vignette and missing vignette builder - this is not resolved here and will be addressed by a future pull request.

Removing any mentions of "master" from github workflows since the default respository for corncob has now switched to "main".

adw96 commented 1 year ago

LGTM! Ok to merge when ready.