statdivlab / rigr

Regression, Inference, and General Data Analysis Tools for R
Other
10 stars 3 forks source link

Editorial comments on JOSS submission #138

Closed osorensen closed 1 year ago

osorensen commented 1 year ago

I'm reading through the JOSS submission, and will post comments as issues in the repository.

My first comment is what you write on lines 66-67: "In the following example, we use regress to fit a linear regression model of atrophy (a measure of global brain activity assessed using MRI) on sex, weight, age, and race."

The part in the parentheses does not seem correct, since atrophy in fact is a measure of tissue loss.

There are a few more things I don't understand about the example application starting on line 62:

I looked this up in the Kuller et al. (2007), and I wonder if what is actually represented by the atrophy variable is white matter grade? Could you please clarify, and if necessary update both the paper and the mri example dataset?

yiqunchen commented 1 year ago

Thanks for your detailed read and clarification! The MRI dataset was originally derived from Kuller et al. (2007) but has been adapted for the use of this package.

In this case, atrophy is measured by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no ventricular enlargement and 100 indicating the most severe degree of atrophy.

We have clarified the text in the submission as follows:

In the following example, we use regress to fit a linear regression model of atrophy (a measure between 0 and 100 of global brain activity measured by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no ventricular enlargement and 100 indicating the most severe degree of atrophy) on sex, weight, age, and race.

Please let us know if you have any other questions; thank you again for your thorough review!

osorensen commented 1 year ago

Thanks for addressing this issue!

I'm still not completely on board, however, since the text still suggests that atrophy is a measure of global brain activity, which it is not.

I suggest rewriting to the following:

In the following example, we use regress to fit a linear regression model of atrophy (a measure between 0 and 100 of loss of neurons estimated by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no ventricular enlargement and 100 indicating the most severe degree of atrophy) on sex, weight, age, and race.

See, e.g., here or here.

yiqunchen commented 1 year ago

Thank you for your great suggestion! In this revision (3ccb5a2), we have edited the sentence to:

In the following example, we use regress to fit a linear regression model of atrophy (a measure of loss of neurons estimated by the degree of ventricular enlargement relative to the predicted ventricular size; with 0 indicating no atrophy and 100 indicating the most severe degree of atrophy) on sex, weight, age, and race.

We really appreciate your reviews!

osorensen commented 1 year ago

Great! Could you please also update the documentation of the atrophy variable in mri dataset accordingly?

That is, here: https://github.com/statdivlab/rigr/blob/0d5f6eb2fa82bd80b3e41fadcdcb90a6694102eb/R/data.R#L95

yiqunchen commented 1 year ago

Thank you for your suggestion -- it has been revised accordingly in https://github.com/statdivlab/rigr/blob/main/R/data.R#:~:text=%27%20%5Citem%7Batrophy%7D%7Ba,degree%20of%20atrophy.%7D

osorensen commented 1 year ago

Thanks!