statdivlab / rigr

Regression, Inference, and General Data Analysis Tools for R
Other
10 stars 3 forks source link

Update regress.R #151

Closed AmeerD closed 4 months ago

AmeerD commented 4 months ago

Fix for Cox model with missing data (see this issue: https://github.com/statdivlab/rigr/issues/148). The following changes were made:

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.23%. Comparing base (a4489c8) to head (d6e8ec8).

:exclamation: Current head d6e8ec8 differs from pull request most recent head 1a9bf66. Consider uploading reports for the commit 1a9bf66 to get more accurate results

Files Patch % Lines
R/regress.R 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #151 +/- ## ======================================= Coverage 72.23% 72.23% ======================================= Files 23 23 Lines 3738 3739 +1 ======================================= + Hits 2700 2701 +1 Misses 1038 1038 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

svteichman commented 4 months ago

Overall this is looking good. There are a few additional updates that I would recommend:

svteichman commented 4 months ago

This looks great! I'd recommend removing the .Rhistory file that is being added, and then it should be all set to merge! You should be able to do this by adding .Rhistory to the .gitignore file on your local fork, although it may require deleting the file in your remote github fork.

svteichman commented 4 months ago

Looks ready to merge to me!