Closed AmeerD closed 4 months ago
Attention: Patch coverage is 66.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 72.23%. Comparing base (
a4489c8
) to head (d6e8ec8
).:exclamation: Current head d6e8ec8 differs from pull request most recent head 1a9bf66. Consider uploading reports for the commit 1a9bf66 to get more accurate results
Files | Patch % | Lines |
---|---|---|
R/regress.R | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Overall this is looking good. There are a few additional updates that I would recommend:
This looks great! I'd recommend removing the .Rhistory file that is being added, and then it should be all set to merge! You should be able to do this by adding .Rhistory to the .gitignore file on your local fork, although it may require deleting the file in your remote github fork.
Looks ready to merge to me!
Fix for Cox model with missing data (see this issue: https://github.com/statdivlab/rigr/issues/148). The following changes were made: