state-machines / state_machines-activemodel

StateMachines ActiveModel Integration
MIT License
33 stars 33 forks source link

account for aliased attributes when attribute methods are mixed in #28

Closed joelvh closed 2 years ago

joelvh commented 3 years ago

Fixes https://github.com/state-machines/state_machines-activemodel/issues/27

Moves alias_attribute fixes from https://github.com/state-machines/state_machines-activerecord/pull/95

joelvh commented 3 years ago

@seuros here's the ActiveModel implementation

joelvh commented 3 years ago

@seuros tests pass locally - I can't see details of the build error.

joelvh commented 3 years ago

@seuros are you interested in merging this rather than https://github.com/state-machines/state_machines-activerecord/pull/95?

joelvh commented 3 years ago

@seuros just checking to see if this is the route to go or the ActiveRecord PR.

joelvh commented 3 years ago

@seuros will this be merged?

seuros commented 2 years ago

Yes, sorry. I'm back at OSSing.

joelvh commented 2 years ago

hi @seuros, thanks for merging this!

Will this also be merged?