state-spaces / s4

Structured state space sequence models
Apache License 2.0
2.39k stars 285 forks source link

does s4_simple.py implement the method explained in the blog? #112

Closed xonobo closed 1 year ago

xonobo commented 1 year ago

There is a link to s4_simple in this blog. However, I cannot match the Chebyshev initialization explained in the blog with the code .

In the code, theta values are multiplied with a values (h_scales). I expect them to be just angles according to blog.

Any guidance or explanation is appreciated.

albertfgu commented 1 year ago

"S4 simple" is not officially supported by this codebase and I'm not sure about its details. To my best knowledge, it is a close variant of S4D-Lin (Paper, Blog). You may have better luck asking the Safari team about that particular line of code.