search

statebox / cql

CQL: Categorical Query Language implementation in Haskell
GNU Affero General Public License v3.0
163 stars 15 forks source link

create http api #102

Closed marcosh closed 5 years ago

marcosh commented 5 years ago

addresses #69

marcosh commented 5 years ago

Moreover, I added the APIs to the main project. I was wondering if it could be a better idea to keep them in a separate package, to that we don't add too many dependencies to the AQL package itself

epost commented 5 years ago

@marcosh yes, absolutely; that's why i wanted the cli dir and project; we could have a http or http-api or api dir or whatever alongside it.

marcosh commented 5 years ago

@epost I addressed your suggestions. Should be fine (or ready for the next round of review) now

marcosh commented 5 years ago

@epost thanks a lot for your feedback! I should have addressed the points your raised. I hope there are no more typos, now...

epost commented 5 years ago

Great stuff, thanks Marco! 👍