search

statebox / cql

CQL: Categorical Query Language implementation in Haskell
GNU Affero General Public License v3.0
162 stars 14 forks source link

Mapping and transform composition #118

Closed wisnesky closed 5 years ago

wisnesky commented 5 years ago

Not sure why there are so many changes below, I thought they were already merged.

epost commented 5 years ago

@wisnesky If you're not seeing certain changes that have already been merged, then the branch you're working on doesn't have them, even though master does. So you could:

1) Have started you branch from a commit on master that already had them; 2) Merge master into your branch so you get those changes too; 3) Rebase on master (perhaps); 4) Wait until this PR is merged into master; I think that should take care of it.

epost commented 5 years ago

Re the <$> vs fmap, that was just a general suggestion, and not a very important one; the fmap version is still there in other places, which is fine. I'll try to emphasise when something is a suggestion in the future. The code standards thing also contains other suggestions for ways of writing things that may be nice in some situations, and less so in others, like the applicative syntax and other things.

wisnesky commented 5 years ago

I couldn't get <$> to replace fmap in the place you suggested, in led to an error. It's possible the lines needed more extensive surgery.