statebox / cql

CQL: Categorical Query Language implementation in Haskell
GNU Affero General Public License v3.0
162 stars 14 forks source link

Add pivot feature. #146 #147

Closed epost closed 4 years ago

epost commented 4 years ago

This takes the pivot feature from ryan4 branch (PR #128) and resolves merge conflicts and other issues as needed.

epost commented 4 years ago

Hi @wisnesky, could you sign off your contribution on this PR using the clahub details link? When that's done, we can merge this. Thanks!

wisnesky commented 4 years ago

Did something change? Why are these pivot contributions triggering a new (re?) licensing request but not any other the other contributions?

On Aug 7, 2019, at 3:35 PM, Erik Post notifications@github.com wrote:

Hi @wisnesky https://github.com/wisnesky, could you sign off your contribution on this PR using the clahub details https://www.clahub.com/agreements/statebox/cql link? When that's done, we can merge this. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/statebox/cql/pull/147?email_source=notifications&email_token=AA2QKN3ZB624W2U4RIUVOS3QDMPZLA5CNFSM4IJLOFKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZPOQQ#issuecomment-519239490, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2QKN5DCIAG2BH5PVAOQILQDMPZLANCNFSM4IJLOFKA.

epost commented 4 years ago

@wisnesky Hmm, I'm not sure; had you signed off before? Maybe it's because this is a new PR rebased on master?

wisnesky commented 4 years ago

Yeah, I signed a PDF over a year ago, not anything online.

On Aug 7, 2019, at 4:03 PM, Erik Post notifications@github.com wrote:

@wisnesky https://github.com/wisnesky Hmm, I'm not sure; had you signed off before? Maybe it's because this is a new PR rebased on master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/statebox/cql/pull/147?email_source=notifications&email_token=AA2QKN474IFEEXDLTGGFV7LQDMTC7A5CNFSM4IJLOFKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZRU5Q#issuecomment-519248502, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2QKN42J6SNQIHA2QVQD7TQDMTC7ANCNFSM4IJLOFKA.

epost commented 4 years ago

@wisnesky Oh! Right, that's the reason then; clahub is an automated service that checks whether every contributor has agreed to the CLA.

epost commented 4 years ago

So @wisnesky, would you mind signing off here so that this PR can be merged? CLA Hub is preventing the merge from happening, probably because it doesn't know about the PDF. (This should be a one-time thing only, if I'm not mistaken.)

wisnesky commented 4 years ago

OK, but for the record I interpret this to mean the original agreement is still in place, and this is a technical fix.

On Aug 7, 2019, at 5:10 PM, Erik Post notifications@github.com wrote:

So @wisnesky https://github.com/wisnesky, would you mind signing off here https://www.clahub.com/agreements/statebox/cql so that this PR can be merged? CLA Hub is preventing the merge from happening, probably because it doesn't know about the PDF. (This should be a one-time thing only, if I'm not mistaken.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/statebox/cql/pull/147?email_source=notifications&email_token=AA2QKN5L2XDZYXWESRVIMULQDM25BA5CNFSM4IJLOFKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ZXANY#issuecomment-519270455, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2QKN6WSQ56KIWSUQGG4A3QDM25BANCNFSM4IJLOFKA.

epost commented 4 years ago

Thanks @wisnesky! 👍 That is my understanding too. @wires, could you chime in?

wires commented 4 years ago

👍 yeah thats correct Ryan, it is not possible with that app to pre-auth people, so everyone has to sign it again. I tried to keep the CLA minimal as a workaround, instead of copying all the legal stuff from the contract verbatim